代码审查 Rietveld and SDK 1.8.1

liuxue.gu@hotmail.com · 2013年06月25日 · 35 次阅读

Andi Albrecht <[email] albrecht.andi@gmail.com[/email]> 13 Jun (12 days ago)

to codereview-dis. Hi all,

starting with the recently released SDK 1.8.1 the default policy to assign IDs to new objects in the datastore changed to use scattered IDs. Those scattered IDs are verrry long, random looking numbers.

Since Rietveld shows the IDs for certain entities (e.g. the issue number) to the user it would be good IMO to allocate the IDs for such entities ourselves, which results in ID series that are similar to the series of IDs generated by the datastore before the 1.8.1 release.

Unfortunately I ran into some issues when changing the way Rietveld retrieves IDs for new issues, patchsets and patches most likely because of this App Engine issue: https://code.google.com/p/googleappengine/issues/detail?id=5431

So there's no quick solution yet.

For all administrators of Rietveld instances on this list: If you upload a version of Rietveld using SDK 1.8.1 the new behavior will be enabled for your instance. Please keep this in mind, when uploading versions to your instance (see http://googlecloudplatform.blogspot.de/2013/06/google-app-engine-181-released.html)

  • except you don't care much about incredibly long numbers :)

Best regards,

Andi

暂无回复。
需要 登录 后方可回复。